ginnoir/romhack-archive-site
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: update catalog to 396 hacks with generations/fakemon fields

Browse Source
This commit is contained in:
ginnoir
2026-06-25 15:56:55 -05:00
parent f3bc721d4a
commit d3647c3eda
6 changed files with 5082 additions and 1043 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/catalog.json
+5020 -1023
View File
File diff suppressed because it is too large Load Diff
src/generated/banner-manifest.json
+1
View File
@@ -171,6 +171,7 @@
"mystery-dungeon-explorers-of-skies": "/assets/banners/mystery-dungeon-explorers-of-skies.jpg",
"mystery-dungeon-wigglytuff-s-bizarre-adventure": "/assets/banners/mystery-dungeon-wigglytuff-s-bizarre-adventure.png",
"mystery-mail-blooming-chaos": "/assets/banners/mystery-mail-blooming-chaos.png",
"myth-2": "/assets/banners/myth-2.png",
"myth": "/assets/banners/myth.png",
"mythic-silver": "/assets/banners/mythic-silver.webp",
"nameless": "/assets/banners/nameless.png",
src/lib/catalog.test.ts
+27
View File
@@ -29,6 +29,8 @@ const baseCatalog: RawCatalog = {
base: 'FireRed',
status: 'Complete',
version: '4.1',
generations: ['Gen I', 'Gen II', 'Gen III', 'Gen IV', 'Gen V', 'Gen VI', 'Gen VII', 'Gen VIII', 'Gen IX'],
fakemon: 'No',
developer: 'Soupercell',
release_date: '2024',
banner: 'https://romhacks-files.ginnoir.com/_meta/radical/banner.jpg',
@@ -104,6 +106,31 @@ describe('catalog normalization', () => {
expect(unknown?.searchText).not.toMatch(/\bnull\b|—/i);
});
it('normalizes roster generations and Fakemon metadata into chips', () => {
const catalog = normalizeCatalog(baseCatalog);
const radical = catalog.hacks.find((hack) => hack.slug === 'radical-red');
expect(radical?.generations).toEqual([
'Gen I',
'Gen II',
'Gen III',
'Gen IV',
'Gen V',
'Gen VI',
'Gen VII',
'Gen VIII',
'Gen IX',
]);
expect(radical?.fakemon).toBe('No');
expect(radical?.chips).toEqual(
expect.arrayContaining([
{ label: 'Roster', value: 'Gen I, Gen II, Gen III, Gen IV, Gen V, Gen VI, Gen VII, Gen VIII, Gen IX', kind: 'generation' },
{ label: 'Fakemon', value: 'No', kind: 'fakemon' },
]),
);
expect(radical?.searchText).toContain('gen ix');
});
it('maps ROM and library paths to internal file-server links', () => {
const catalog = normalizeCatalog(baseCatalog);
const radical = catalog.hacks.find((hack) => hack.slug === 'radical-red');
src/lib/catalog.ts
+8
View File
@@ -56,6 +56,8 @@ export function normalizeHack(raw: RawHack): SiteHack {
const developer = cleanText(raw.developer);
const releaseDate = cleanText(raw.release_date);
const generation = cleanText(raw.generation);
const generations = cleanList(raw.generations);
const fakemon = cleanText(raw.fakemon);
const scrapeDir = cleanText(raw.scrape_dir);
const libraryPath = cleanText(raw.library_path);
const banner = cleanText(raw.banner);
@@ -74,6 +76,8 @@ export function normalizeHack(raw: RawHack): SiteHack {
version,
status,
generation,
generations,
fakemon,
developer,
releaseDate,
banner,
@@ -106,10 +110,12 @@ export function normalizeHack(raw: RawHack): SiteHack {
hack.version,
hack.developer,
hack.releaseDate,
hack.fakemon,
hack.summary,
hack.notability,
hack.story,
...hack.types,
...hack.generations,
...hack.features,
]
.filter(Boolean)
@@ -216,6 +222,8 @@ function buildChips(hack: SiteHack): HackChip[] {
addChip(chips, 'status', 'Status', hack.status);
addChip(chips, 'developer', 'Dev', hack.developer);
addChip(chips, 'release_date', 'Release', hack.releaseDate);
addChip(chips, 'generation', 'Roster', hack.generations.join(', '));
addChip(chips, 'fakemon', 'Fakemon', hack.fakemon);
for (const type of hack.types) {
addChip(chips, 'type', 'Type', type);
}
src/lib/types.ts
+5 -1
View File
@@ -20,6 +20,8 @@ export interface RawHack {
version?: string | null;
status?: string | null;
generation?: string | null;
generations?: string[] | null;
fakemon?: string | null;
developer?: string | null;
release_date?: string | null;
banner?: string | null;
@@ -46,7 +48,7 @@ export interface ExternalLink {
export interface HackChip {
label: string;
value: string;
kind: 'platform' | 'base' | 'version' | 'status' | 'developer' | 'release_date' | 'type';
kind: 'platform' | 'base' | 'version' | 'status' | 'developer' | 'release_date' | 'generation' | 'fakemon' | 'type';
}
export interface FileLink {
@@ -64,6 +66,8 @@ export interface SiteHack {
version?: string;
status?: string;
generation?: string;
generations: string[];
fakemon?: string;
developer?: string;
releaseDate?: string;
banner?: string;
tests/catalog.spec.ts
+21 -19
View File
@@ -11,23 +11,23 @@ test('homepage presents balanced navigation and facet summaries', async ({ page
await expect(primaryNav.getByRole('link', { name: 'Difficulty' })).toHaveCount(0);
const heroStats = page.locator('.hero-stats');
await expect(heroStats).toContainText('368');
await expect(heroStats).toContainText('396');
await expect(heroStats).toContainText('hacks');
await expect(heroStats).toContainText('Platforms');
await expect(heroStats).toContainText('GBA 188');
await expect(heroStats).toContainText('GBA 197');
await expect(heroStats).toContainText('NDS 47');
await expect(heroStats).toContainText('PC 40');
await expect(heroStats).toContainText('GBC 22');
await expect(heroStats).toContainText('PC 66');
await expect(heroStats).toContainText('GBC 36');
await expect(heroStats).toContainText('Types');
await expect(heroStats).toContainText('Expansion 143');
await expect(heroStats).toContainText('New Experience 129');
await expect(heroStats).toContainText('Difficulty 105');
await expect(heroStats).toContainText('QoL 50');
await expect(heroStats).toContainText('Expansion 144');
await expect(heroStats).toContainText('New Experience 156');
await expect(heroStats).toContainText('Difficulty 108');
await expect(heroStats).toContainText('QoL 54');
await expect(heroStats).toContainText('Status');
await expect(heroStats).toContainText('Complete 168');
await expect(heroStats).toContainText('Ongoing 28');
await expect(heroStats).toContainText('Beta 10');
await expect(heroStats).toContainText('Unclassified 161');
await expect(heroStats).toContainText('Complete 196');
await expect(heroStats).toContainText('Ongoing 34');
await expect(heroStats).toContainText('Beta 12');
await expect(heroStats).toContainText('Unclassified 153');
});
test('homepage stat cards are polished and responsive', async ({ page }) => {
@@ -72,12 +72,12 @@ test('homepage browse summary links to grouped facet pages', async ({ page }) =>
const browse = page.getByRole('region', { name: 'Browse by catalog facets' });
await expect(browse.getByRole('heading', { name: 'Browse the archive' })).toBeVisible();
await expect(browse.getByRole('link', { name: /GBA\s+188/ })).toHaveAttribute('href', '/browse/platform/gba/');
await expect(browse.getByRole('link', { name: /Difficulty\s+105/ })).toHaveAttribute(
await expect(browse.getByRole('link', { name: /GBA\s+197/ })).toHaveAttribute('href', '/browse/platform/gba/');
await expect(browse.getByRole('link', { name: /Difficulty\s+108/ })).toHaveAttribute(
'href',
'/browse/type/difficulty/',
);
await expect(browse.getByRole('link', { name: /Complete\s+168/ })).toHaveAttribute(
await expect(browse.getByRole('link', { name: /Complete\s+196/ })).toHaveAttribute(
'href',
'/browse/status/complete/',
);
@@ -89,7 +89,7 @@ test('catalog search and filters update visible card count', async ({ page }) =>
await expect(page).toHaveTitle(/ROM Hack Archive/);
await expect(page.getByRole('heading', { name: 'ROM Hack Archive' })).toBeVisible();
const catalogCards = page.locator('[data-card-grid] [data-card]:visible');
await expect(catalogCards).toHaveCount(368);
await expect(catalogCards).toHaveCount(396);
await page.getByPlaceholder('Search hacks').fill('Radical Red');
await expect(catalogCards).toHaveCount(4);
@@ -97,7 +97,7 @@ test('catalog search and filters update visible card count', async ({ page }) =>
await page.getByPlaceholder('Search hacks').fill('');
await page.getByLabel('GBA').check();
await expect(catalogCards).toHaveCount(188);
await expect(catalogCards).toHaveCount(197);
await page.getByLabel('Difficulty').check();
await expect(catalogCards.first()).toBeVisible();
@@ -181,10 +181,12 @@ test('detail page renders metadata and private file links', async ({ page }) =>
await expect(page.getByRole('heading', { name: 'Pokémon Radical Red' })).toBeVisible();
await expect(page.getByText('Platform').first()).toBeVisible();
await expect(page.getByText('Roster').first()).toBeVisible();
await expect(page.getByText('Fakemon').first()).toBeVisible();
await expect(page.getByRole('heading', { name: 'Files' })).toBeVisible();
await expect(page.getByRole('link', { name: 'ROM file' })).toHaveAttribute(
'href',
/https:\/\/romhacks-files\.ginnoir\.com\/_roms\/gba\/Hacks\//,
/https:\/\/romhacks-files\.ginnoir\.com\/_roms\/gba\/Pokemon%20-%20Radical%20Red/,
);
await expect(page.locator('body')).not.toContainText('undefined');
});
@@ -193,6 +195,6 @@ test('browse pages render static grouped lists', async ({ page }) => {
await page.goto('/browse/type/difficulty/');
await expect(page.getByRole('heading', { name: 'Difficulty' })).toBeVisible();
await expect(page.locator('[data-card]:visible')).toHaveCount(105);
await expect(page.locator('[data-card]:visible')).toHaveCount(108);
await expect(page.getByRole('link', { name: /Open Pokémon Radical Red/ })).toBeVisible();
});