refactor(state): fix code quality findings for nav panel store and prefs

2026-06-11 21:12:20 -05:00
parent 9b2793b264
commit 09e2d06b87
4 changed files with 75 additions and 12 deletions
@@ -69,13 +69,13 @@ export const useGameStore = create<GameStoreState>((set) => ({
  setSettingsOpen: (open) => set({ settingsOpen: open }),
  setActivePanel: (panel) => set({ activePanel: panel }),
  setSelectedStoryNodeId: (id) => set({ selectedStoryNodeId: id }),
-  toggleActionGroupCollapsed: (groupKey) =>
-    set((state) => {
-      const nextCollapsed = {
-        ...state.prefs.collapsedActionGroups,
-        [groupKey]: !state.prefs.collapsedActionGroups[groupKey],
-      };
-      const prefs = persistPrefs({ collapsedActionGroups: nextCollapsed });
-      return { prefs };
-    }),
+  toggleActionGroupCollapsed: (groupKey) => {
+    const currentPrefs = useGameStore.getState().prefs;
+    const nextCollapsed = {
+      ...currentPrefs.collapsedActionGroups,
+      [groupKey]: !currentPrefs.collapsedActionGroups[groupKey],
+    };
+    const prefs = persistPrefs({ collapsedActionGroups: nextCollapsed });
+    set({ prefs });
+  },
 }));