fix(agent): validate assistant model requests

This commit is contained in:
ginnoir
2026-07-08 16:15:19 -05:00
parent 0bf63cf8a8
commit 876e72671a
2 changed files with 44 additions and 6 deletions
+40 -1
View File
@@ -29,7 +29,13 @@ describe("normalizeLlmModelsPayload", () => {
it("ignores invalid or empty model rows", () => {
const models = normalizeLlmModelsPayload({
data: [{ id: "" }, { id: " " }, { id: "bad model" }, { object: "model" }],
data: [
{ id: "" },
{ id: " " },
{ id: "bad model" },
{ id: " llama3.2 " },
{ object: "model" },
],
});
assert.deepEqual(models, []);
@@ -111,6 +117,39 @@ describe("resolveAssistantModel", () => {
});
it("rejects invalid requested models", () => {
const resolved = resolveAssistantModel({
requestedModel: "bad model",
savedModel: null,
fallbackModel: "llama3.2",
models: [
{ id: "llama3.2", label: "llama3.2" },
{ id: "bad model", label: "bad model" },
],
});
assert.deepEqual(resolved, {
ok: false,
model: "llama3.2",
error: "Invalid assistant model",
});
});
it("rejects empty requested models", () => {
const resolved = resolveAssistantModel({
requestedModel: "",
savedModel: null,
fallbackModel: "llama3.2",
models: [{ id: "llama3.2", label: "llama3.2" }],
});
assert.deepEqual(resolved, {
ok: false,
model: "llama3.2",
error: "Invalid assistant model",
});
});
it("rejects unavailable requested models", () => {
const resolved = resolveAssistantModel({
requestedModel: "missing",
savedModel: null,